Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aspnetcore] Fix nullable warnings part 1 #15555

Merged
merged 2 commits into from
May 18, 2023

Conversation

JFCote
Copy link
Member

@JFCote JFCote commented May 17, 2023

This is part 1 of an ongoing effort to remove most warning from the code generation for ASP .NET Core server.
They are mostly linked to bad handling of nullable.

Technical committee: @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@JFCote JFCote requested a review from jimschubert as a code owner May 17, 2023 12:10
@JFCote JFCote requested a review from wing328 May 17, 2023 12:10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use {{nrt?}} instead of {{#nullableReferenceTypes}}?{{/nullableReferenceTypes}}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I didn't know! Should I change my code?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its the same just shorter.

@wing328
Copy link
Member

wing328 commented May 18, 2023

thanks for the PR. let's give it a try.

@wing328 wing328 merged commit b7dc6ce into master May 18, 2023
28 of 29 checks passed
@wing328 wing328 added Server: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels May 18, 2023
@wing328 wing328 added this to the 7.0.0 milestone May 18, 2023
@wing328 wing328 deleted the features/fix-nullable-warnings-part1 branch May 18, 2023 03:20
@wing328
Copy link
Member

wing328 commented May 18, 2023

samples updated via d8ed253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: C-Sharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants