Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript] fix use of isBasicBasic and isBasicBearer conditions #15522

Merged

Conversation

tiffmaelite
Copy link
Contributor

Follow-up of #15220 but for other generators

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)

@wing328 wing328 added this to the 7.0.0 milestone May 16, 2023
@wing328 wing328 merged commit 016507c into OpenAPITools:master May 16, 2023
5 of 6 checks passed
@tiffmaelite tiffmaelite deleted the fix/fix_use_isBasic_javascript branch May 16, 2023 07:58
@@ -117,12 +117,12 @@ export const {{classname}}FetchParamCreator = function (configuration?: Configur
}
{{/isKeyInQuery}}
{{/isApiKey}}
{{#isBasic}}
{{#isBasicBasic}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 note: this is not only about documentation: it fixes the fact that the below lines would be generated in case of operations with bearer or signature auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants