Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommission python-legacy, python-prior client generators #15475

Merged
merged 3 commits into from
May 12, 2023
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 11, 2023

Decommission python-legacy, python-prior client generators

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @arun-nalla (2019/11) @spacether (2019/11) @krjakbrjak (2023/02)

@wing328 wing328 marked this pull request as ready for review May 11, 2023 08:40
@spacether
Copy link
Contributor

spacether commented May 11, 2023

Will the python generator be removed in this PR too?

How about mentioning in this PR description that if people want to continue using the python generator that they can do so from it's new home at https://github.com/openapi-json-schema-tools/openapi-json-schema-generator?

@wing328
Copy link
Member Author

wing328 commented May 12, 2023

python generator will be removed in another PR instead. This PR has nothing to do with python generator.

Of course you can leave a comment mentioning openapi-json-schema-generator.

@wing328 wing328 merged commit 3371e88 into master May 12, 2023
7 checks passed
@wing328 wing328 deleted the deco-py branch May 12, 2023 05:46
@spacether
Copy link
Contributor

spacether commented May 14, 2023

Fyi many projects will need to pick a different python generator when they upgrade to v7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants