Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin][client] Small improvements #15429

Merged
merged 3 commits into from
May 9, 2023

Conversation

WonderCsabo
Copy link
Contributor

@WonderCsabo WonderCsabo commented May 5, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

@WonderCsabo
Copy link
Contributor Author

@4brunu i addressed all review comments.

@4brunu 4brunu merged commit da9ad4a into OpenAPITools:master May 9, 2023
@4brunu
Copy link
Contributor

4brunu commented May 9, 2023

Looks good to me 👍

@wing328 wing328 added this to the 6.6.0 milestone May 9, 2023
@WonderCsabo WonderCsabo deleted the kotlin-updates branch May 10, 2023 08:03
@WonderCsabo
Copy link
Contributor Author

@4brunu thanks for the reviews!

@4brunu
Copy link
Contributor

4brunu commented May 10, 2023

@WonderCsabo Thank you for taking the time to improve openapi-generator 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants