-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kotlin][client] Small improvements #15429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonderCsabo
commented
May 5, 2023
samples/client/petstore/kotlin/src/main/kotlin/org/openapitools/client/models/User.kt
Show resolved
Hide resolved
...kotlin-retrofit2-kotlinx_serialization/src/main/kotlin/org/openapitools/client/models/Pet.kt
Outdated
Show resolved
Hide resolved
4brunu
reviewed
May 5, 2023
samples/client/petstore/kotlin-retrofit2/src/main/kotlin/org/openapitools/client/apis/PetApi.kt
Outdated
Show resolved
Hide resolved
4brunu
reviewed
May 5, 2023
modules/openapi-generator/src/main/resources/kotlin-client/enum_class.mustache
Outdated
Show resolved
Hide resolved
… enums when using moshi library This is needed, so the moshi generated R8 rules will include the enum classes: https://github.com/square/moshi#enums
WonderCsabo
force-pushed
the
kotlin-updates
branch
from
May 8, 2023 14:58
3714365
to
5811d03
Compare
@4brunu i addressed all review comments. |
Looks good to me 👍 |
@4brunu thanks for the reviews! |
@WonderCsabo Thank you for taking the time to improve openapi-generator 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m