Serialization bug fix #15413
Merged
Serialization bug fix #15413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
wing328
added a commit
that referenced
this pull request
May 5, 2023
…type (#15377) * better handling of oneOf/anyOf with duplicated data type * update generichost template * remove newline in eof * bug fix (#15413) --------- Co-authored-by: devhl-labs <[email protected]>
wing328
reviewed
May 5, 2023
| writer.WriteStartObject(); | ||
|
|
||
| {{/isInherited}} | ||
| {{/composedSchemas.allOf}} |
There was a problem hiding this comment.
looks like these 2 lines should move up to line 231 as currently we get
[pool-1-thread-2] Generation failed for csharp-netcore: (RuntimeException) Could not generate model 'apple'
java.lang.RuntimeException: Could not generate model 'apple'
at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:569)
at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:926)
at org.openapitools.codegen.cmd.GenerateBatch$GenerationRunner.run(GenerateBatch.java:232)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: com.samskivert.mustache.MustacheParseException: Section close tag with mismatched open tag 'isInherited' != 'composedSchemas' @ line 235
at com.samskivert.mustache.Mustache$Accumulator.requireSameName(Mustache.java:754)
at com.samskivert.mustache.Mustache$Accumulator$2.addCloseSectionSegment(Mustache.java:705)
at com.samskivert.mustache.Mustache$Accumulator.addTagSegment(Mustache.java:713)
at com.samskivert.mustache.Mustache$Parser.parseChar(Mustache.java:573)
at com.samskivert.mustache.Mustache$Parser.parse(Mustache.java:471)
There was a problem hiding this comment.
filed #15424 to fix/workaround it for the time being.
please take another look when you've time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes to existing pr, just build samples.