-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPRING] Generate constants for paths (#1385) #1532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a nice addition to the Spring generator.
Nice addition, I already did it it 'kind of' with using custom templates. But we've generated the paths in the same api interface. Will be this available in 4.0.0 release ? |
package {{package}}; | ||
|
||
{{#operations}} | ||
public interface {{classname}}Route { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constants should not be defined in interfaces : https://rules.sonarsource.com/java/tag/bad-practice/RSPEC-1214
What is the gain of this ? I find it easier to read URLs directly in controllers. But that may be just me... |
Closing this as there's no update @adrianiacobghiula let us know if you still want to proceed with this PR. |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.4.x
,4.0.x
. Default:master
.@diyfr
@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)
@wing328
Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)