Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-ue4] Fix multi collection format has duplicated prefix #15260

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

nullbus
Copy link
Contributor

@nullbus nullbus commented Apr 19, 2023

Hello, I made another pull request that addresses different issue. Query parameter generation works very well except "multi" collection format. CollectionToUrlString_multi generates "key=value1&key=value2&..." like string and if used with query string, duplicated key string is appended like:

key=key=value1&key=value2

This commit separates "multi" type collection query string generation from other types.

@Kahncode

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Kahncode
Copy link
Contributor

Looks good, I don't think I have ever been able to test properly with this case.

@wing328 wing328 added this to the 6.6.0 milestone Apr 21, 2023
@wing328 wing328 merged commit e6c64d3 into OpenAPITools:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants