Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic JSON body support in rust-server #1523

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Generic JSON body support in rust-server #1523

merged 2 commits into from
Dec 4, 2018

Conversation

mthebridge
Copy link
Contributor

PR checklist

  • [ X ] Read the contribution guidelines.
  • [ X ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ X ] Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • [X ] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Generates valid rust for an arbitrary JSON response body of type object with no other schema.

@frol @farcaller @bjgill

Copy link
Contributor

@bjgill bjgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

I'll wait until Friday, to give other people a chance to review, before merging.

@bjgill bjgill self-assigned this Nov 26, 2018
@wing328 wing328 added this to the 4.0.0 milestone Dec 4, 2018
@bjgill
Copy link
Contributor

bjgill commented Dec 4, 2018

Right. Let's get this merged, then.

@bjgill bjgill merged commit 4930f75 into OpenAPITools:master Dec 4, 2018
@bjgill bjgill deleted the generic-json-bodies branch December 4, 2018 16:52
@wing328
Copy link
Member

wing328 commented Jan 2, 2019

@mthebridge thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529.

Happy New Year and looking forward to more collaboration and contributions in 2019!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants