-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Zone.js to remove warnings when using angular >=6. #1522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
I think the zone.js dependency could be removed from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw that the angular 2/4 samples are also affected, this should not be the case, since the zone.js dependency should remain 0.7.6
int that case
@macjohnny ok, what do you suggest? Should I remove the zonejs dependencies since we already depend on And regarding the change on angular2/4 samples, what should I do there? I just regenerated all the angular samples with |
@d0x I suggest to remove the |
Ok, I think we have it then. I removed it and regenerated the templates. |
@d0x thanks for the PR, which has been included in the v3.3.4 release: https://twitter.com/oas_generator/status/1068772409795207168 |
…>=6. (OpenAPITools#1522) * 1506 allow zonejs 0.7.x and 0.8.x to support a wider range of angular versions * OpenAPITools#1506 Removed zone.js as peer since it comes with angular itself * OpenAPITools#1506 Removed zone.js as peer since it comes with angular itself
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.4.x
,4.0.x
. Default:master
.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)
Description of the PR
Fixed #1506 . Bump Zone.js peer dependency. Angular 6 and 7 is using Zone.js 0.8.26. I tested zone.js 0.8.26 in our environment with Angular 6.
Since it shouldn't break anything, the current master branch is correct, or?
@Committee: I used the syntax
^0.7.6 || ^0.8.26
to support a wider range of angular versions. What do you think about this?And why
./bin/typescript-angular-petstore-all.sh
doesn't put this syntax into the generated package.jsons?