Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-netcore] Updated package versions #15173

Merged
merged 1 commit into from
May 16, 2023

Conversation

devhl-labs
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 16, 2023

Opening samples/client/petstore/csharp-netcore/OpenAPIClient/Org.OpenAPITools.sln and then running the tests locally result in the following repeatly (and the test run didn't finish):

Screen Shot 2023-05-16 at 5 31 41 pm

Is the test running fine in your environment?

You may need to run the Petstore server tests locally: https://github.com/OpenAPITools/openapi-generator/wiki/Integration-Tests#how-to-add-integration-tests-for-new-petstore-samples

@wing328 wing328 merged commit 1210229 into OpenAPITools:master May 16, 2023
@devhl-labs devhl-labs deleted the version-bump branch May 17, 2023 01:08
@devhl-labs
Copy link
Contributor Author

There were no test failures so I thought it was fine, but on the right you can see something did fail. It is a stack overflow in PetTests#TestEqual at Assert.True(category1.Equals(category2));
image

And here is the cause. If that library gets fixed we can update. If anyone is affected, we can revert this change if useCompareNetObjects is enabled. Though I wonder if we really need this library.
https://github.com/GregFinzer/Compare-Net-Objects/issues/282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants