[swift] to support application/octet-stream for file upload #15140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Apr 26, 2023
| @@ -618,6 +620,24 @@ private class FormURLEncoding: ParameterEncoding { | |||
| } | |||
| } | |||
|
|
|||
| private class OctetStreamEncoding: ParameterEncoding { | |||
There was a problem hiding this comment.
thanks for the PR. can you please add a line or 2 explaining what this class (and function encode) does?
wing328
changed the title
|
Erm. This is swift 🙂 |
wing328
changed the title
wing328
changed the title
|
oops.. sorry. thanks for the correction |
4brunu
reviewed
Apr 26, 2023
| @@ -128,6 +128,8 @@ private var credentialStore = SynchronizedDictionary<Int, URLCredential>() | |||
| encoding = FormDataEncoding(contentTypeForFormPart: contentTypeForFormPart(fileURL:)) | |||
| } else if contentType.hasPrefix("application/x-www-form-urlencoded") { | |||
| encoding = FormURLEncoding() | |||
| } else if contentType.hasPrefix("application/octet-stream"){ | |||
There was a problem hiding this comment.
@aniruddhJo Hi, thanks for creating this PR.
Could you please also add support for application/octet-stream in alamofire please?
Thanks
There was a problem hiding this comment.
created a ticket to track this: #16300
This was referenced Aug 11, 2023
|
closed via #16299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #15129
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)