Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaDoc fixes for Java/RESTEasy client #151

Merged
merged 3 commits into from
May 26, 2018

Conversation

delenius
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

I added/fixed JavaDoc comments in the mustache templates for the Java/RESTEasy client, so that it no longer generates errors and warnings when running javadoc on the generated code.
I also modified the pom template so that it creates the javadoc automatically, to be consistent with the other clients.

@wing328
Copy link
Member

wing328 commented May 25, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@delenius
Copy link
Contributor Author

Thanks for the heads up, forgot about that. Will fix momentarily...

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. I'll merge it once the CI tests pass.

Oops, I missed some stuff when I ported over this PR.
@jmini
Copy link
Member

jmini commented May 26, 2018

CircleCI fail is not related to this change.

Thank you a lot for this change.

@jmini jmini merged commit 4d7ff8c into OpenAPITools:master May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants