-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swift5): allow to swift build in linux #15060
Conversation
@gierschv thanks for the PR. I wonder if you've time to setup a github workflow to test the Swift 5 petstore sample(s) similar to This can help ensure the swift client built on linux as well as part of this PR. |
9a8de28
to
bf9dff8
Compare
271a94c
to
e6d2c18
Compare
1a3e820
to
0458366
Compare
@wing328 Sure, done! I tried adding the CI for the other samples on OSX, but ran into some issues importing CoreServices and stuff around mime types (e.g. I ended up only sticking with adding AlamoFire in the CI that have the platform support for Linux. |
aec9241
to
deafc2b
Compare
@wing328 I think we are good to merge. The swift5 samples are now built on OSX + Except |
deafc2b
to
7d09e81
Compare
Agreed that issue has nothing to do with this PR. Thanks for the PR, which has been merged. Have a nice weekend. |
This PR adds the import of FoundationNetworking to the swift 5 templates so we can build the generated code in linux machines & CI.
I noticed that Alamofire recently released to added the linux as well, so it's great to be able to test in our linux CI if the generated code actually builds and has no syntax error (that happens sometimes).
I'm not sure if this project have any Linux CI process to test the generated code, but we could add those
swift build
if anyPR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)