Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isOverridden, update Java pojo with setter for parent properties #15051

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Mar 26, 2023

  • Add isOverridden to indicate a property (in allVars) belongs to the parent model
  • update Java pojo with setter for parent properties

To close #14915

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

cc @OpenAPITools/generator-core-team

@devhl-labs
Copy link
Contributor

Can't you get the same information from isInherited and isNew?

@wing328
Copy link
Member Author

wing328 commented Mar 27, 2023

tried these 2 but looks like these 2 attributes only work in certain generators.

tried to fix/add these 2 attributes in default codegen but that results in a lot of change in samples that I do not have time to go over one by one.

@wing328 wing328 merged commit 9fa032b into master Mar 29, 2023
@wing328 wing328 deleted the fix-14915 branch March 29, 2023 02:57
@Willem1987
Copy link

@wing328 Im having trouble with thing change, but i don't know if it is misusage or a bug.

I tried sharing a class along modules and have a multi layered model(base, extend1, extend 2, dto).
When using importmapping the isOverriden sees properties as Overridden and adds @OverRide, while the direct superclass does not have a similar builder/setter method.

Id rather not have custom templates that I need to keep in line. Would it be possible to use the imported class to check whether to add @OverRide on the child method or somehow avoid the whole builder method effect?

I'd be willing to put in some work for a PR. For now i seemed to workaround it leaving all the properties in the child class but that feels like a lot of duplication for an allof structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] Fluent setters from inherited from parent return parents type
4 participants