Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin-server] fix bean validation site targets #14997

Merged
merged 1 commit into from
May 18, 2023

Conversation

stephan-strate
Copy link
Contributor

@stephan-strate stephan-strate commented Mar 20, 2023

Changed the site target of jax-rs specific annotations for generated models to @field. That allows the validator to see these annotations and validate accordingly.

fixes #12351

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@stephan-strate
Copy link
Contributor Author

@stephan-strate
Copy link
Contributor Author

Any opinion on that?

@gdiegel
Copy link

gdiegel commented May 18, 2023

@jimschubert Could this be merged? I'm currently struggling with bean validation not working with the kotlin-server generator and this PR would fix it.

@4brunu 4brunu merged commit 2250aae into OpenAPITools:master May 18, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Kotlin's kotlin-server generator does not support bean validation
4 participants