-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[erlang-client] fix URL paths #14988
Conversation
* integers parameters in URL did not work as expected * so now, if the parameter is an integer, we convert it to binary before passing to `hackney_url:make_url/3`
1> petstore_pet_api:get_pet_by_id(#{}, 5, #{cfg => #{host => <<"https://petstore.swagger.io">>}}).
{ok,#{category => #{id => 0,name => <<"string">>},
id => 5,name => <<"doggie">>,
photoUrls => [<<"string">>],
status => <<"string">>,
tags => [#{id => 0,name => <<"string">>}]},
#{headers =>
[{<<"Date">>,<<"Fri, 17 Mar 2023 21:50:29 GMT">>},
{<<"Content-Type">>,<<"application/json">>},
{<<"Transfer-Encoding">>,<<"chunked">>},
{<<"Connection">>,<<"keep-alive">>},
{<<"Access-Control-Allow-Origin">>,<<"*">>},
{<<"Access-Control-Allow-Methods">>,
<<"GET, POST, DELETE, PUT">>},
{<<"Access-Control-Allow-Headers">>,
<<"Content-Type, api_key, Authorization">>},
{<<"Server">>,<<"Jetty(9.2.9.v20150224)">>}],
status => 200}} |
5.3.0-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like your fix is not based on the latest master. i'll update the samples after merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 hrm I thought I had branched off of the latest master. is there something I should normally do when switching to the master branch to make sure the correct version is used normally?
FYI. @tsloughter (2017/11) @jfacorro (2018/10) @robertoaloi (2018/10) |
tests with updated samples passed via #15016 |
samples updated via 38d9dc1 |
hackney_url:make_url/3
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)