Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-netcore] Moved null checks from constructor to JsonConverter #14980

Merged

Conversation

devhl-labs
Copy link
Contributor

Moving the null checks to the JsonConverter. Its a bit unusual to have them in the constructor, and not flexible. It is easy for users to replace converters in the event users do not want the null checks. The only reason they are there at all is because System.Text.Json does not have missing members support like Newtonsoft.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@devhl-labs
Copy link
Contributor Author

The diff is not related.

@wing328 wing328 added Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Mar 17, 2023
@wing328 wing328 added this to the 6.5.0 milestone Mar 17, 2023
@wing328
Copy link
Member

wing328 commented Mar 17, 2023

CI failure (samples outdated) already fixed in the master.

@wing328 wing328 merged commit 02b6248 into OpenAPITools:master Mar 17, 2023
@devhl-labs devhl-labs deleted the move-null-checks-to-json-converter branch March 17, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants