Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][Jersey2/3] Probe content type for multipart upload parts #14965

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

jdimeo
Copy link
Contributor

@jdimeo jdimeo commented Mar 15, 2023

Many servers throw errors if the multipart upload doesn't correctly identify the part. If a file is passed in to be uploaded, we can use NIO APIs to probe the content type more specifically. In the case of any error, we fall back to the previous default MediaType.APPLICATION_OCTET_STREAM_TYPE.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jdimeo
Copy link
Contributor Author

jdimeo commented Mar 15, 2023

I notice some tests failed, and it seems related (because it's mentioning an upload of a .png as the last log line) but as far as I can tell, it's not related (since it's in the Typescript test suite).

@wing328
Copy link
Member

wing328 commented Apr 13, 2023

https://github.com/OpenAPITools/openapi-generator/actions/runs/4692047648/jobs/8317426213?pr=14965

can you please update the samples when you've time?

@jdimeo
Copy link
Contributor Author

jdimeo commented Apr 13, 2023

https://github.com/OpenAPITools/openapi-generator/actions/runs/4692047648/jobs/8317426213?pr=14965

can you please update the samples when you've time?

OK I've done that and it looks like all the checks passed. thanks

@wing328 wing328 merged commit 90b78fe into OpenAPITools:master Apr 14, 2023
@wing328 wing328 changed the title Jersey2/3 - Probe content type for multipart upload parts [java][Jersey2/3] Probe content type for multipart upload parts Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants