-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Java][webclient/resttemplate] fix dependencies for gradle with jakarta enabled #14925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][webclient/resttemplate] fix dependencies for gradle with jakarta enabled #14925
Conversation
modules/openapi-generator/src/main/resources/Java/libraries/webclient/build.gradle.mustache
Outdated
Show resolved
Hide resolved
e7a4ce1 to
26e11f4
Compare
|
welshm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
@ChristianMoesl could you please check failed pipelines? For "Samples up-to-date" just pull latest master and ensure that you have regenerated samples for all project that are affected by your change |
350b22d to
3066a07
Compare
3066a07 to
3d03261
Compare
|
@borsch I fixed the issues, which caused the pipeline to fail. There were 3 things to fix:
|
|
Not sure that exclusively supporting grade 8 is a good idea.. This simply means that we would force all clients of this generator to start using grade 8 FYI @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) |
|
Sry, I should have clarified the Gradle compatibility for this. So overall, the generated code will be compatible with Gradle >= 6.7, which sounds reasonable to me. Especially because the template generates a Gradle wrapper with version 7.2 anyway. |
This PR fixes build errors, because of wrong dependencies in the gradle build templates for java clients with spring dependencies (webclient & resttemplate) and
useJakartaEeenabled.This error can be reproduced quite easily on
masterbranch with the following commands:It will result in build errors like these:

What was done:
useJakartaEeis enabled (only jakarta 2.0 and above exposes annotations injakarta.annotations.*namespace)PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)