Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to simplify oneOf/anyOf #14777

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Add rule to simplify oneOf/anyOf #14777

merged 4 commits into from
Feb 21, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 21, 2023

Add rule (SIMPLIFY_ONEOF_ANYOF) to simplify oneOf/anyOf

  • remove null (sub-schema) and set nullable to true instead
  • simplify oneOf/anyOf with a single sub-schema to just the sub-schema itself

FYI @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added Enhancement: Feature OpenAPI Normalizer Normalize the spec for easier processing labels Feb 21, 2023
@wing328 wing328 added this to the 6.5.0 milestone Feb 21, 2023
@wing328 wing328 merged commit e091962 into master Feb 21, 2023
@wing328 wing328 deleted the simplify-oneof-anyof branch February 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Feature OpenAPI Normalizer Normalize the spec for easier processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant