-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swift5] fix modelNamePrefix and -suffix for reserved types #14768
Conversation
not sure why but the build failed despite restarting the job:
ref: https://app.bitrise.io/build/06be2061-7dd9-4c06-8ad4-4a12bc4ef4ac can you please take a look when you've time? |
8d99830
to
af316ae
Compare
@wing328 fixed. swift5 samples currently must not use default package name but must define a custom name instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Fixes #11185
We need to check for reserved types which must not be prefixed or suffixed. I added the
AnyCodable
type tolanguageSpecificPrimitives
which is technically not a language type but a type from dependency. If this is not correct I can add a second array to hold potential reserved public types from dependencies. Please provide feedback what is preferred hereAdded a new sample to check for prefix and suffix functionalities
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)Declaration
The program was tested solely for our own use cases, which might differ from yours.
Link to provider information
https://github.com/mercedes-benz