-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java][apache-httpclient] update httpclient dependency to the latest 5.x #14673
Conversation
@andrevegas thanks for the PR. What about updating the existing apache-httpclient to 5.x version instead of adding another library? |
Hi @wing328, sure that's definitely a feasible option and happy to adjust the PR towards that. |
how urgent do you need the httpclient 5.x support? if it's not urgent, we can target 7.0.0 (to be released in 3 to 5 months from now). |
4.5.14 - Nov 30, 2022 These are the release dates of the 4.x version. I prefer update |
@wing328 Ideally we need'd need that before end of the month (before our next release), but I understand that may not be possible based on this project timeline. I will update the PR/branch to replace the version 4 with the 5 instead. |
From the CI: https://github.com/OpenAPITools/openapi-generator/actions/runs/4158656772/jobs/7196209435 looks like the sample is not yet up-to-date. can you please update the samples when you've time? |
overall it looks good 👍 |
@wing328 done. I had run Can you pls share some light on next steps? Would you be able to merge/incorporate this change/enhancement straight away? Or it goes into some sort of release schedule? Thanks. |
LGTM. Let's include this in the upcoming v6.4.0 release. Thanks for the PR. |
secret breaking change :| Updating the library causes generation to break between 6.3.0 and 6.4.0 for any applications that do any customization of the generated library. Spring Framework changed the default Apache HttpClient implementation between 5.x and 6.x. Having this change completely separate from that is a real bummer, this really should have been handled as a separate library. It doesn't make sense to me to upgrade major breaking versions, but instead to handle this as is already done for Jersey and support 1.x and 2.x etc. |
To close #14672
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)