Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Fix escaping in templates #14572

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

avandecreme
Copy link
Contributor

@avandecreme avandecreme commented Jan 31, 2023

This spec generates failing code (error during R CMD check) because some fields have an underscore prefix.
This PR adds some backticks where necessary.

@Ramanth @saigiridhar21

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@avandecreme avandecreme force-pushed the fix_r_escaping branch 2 times, most recently from 4d448d7 to 7b147f8 Compare February 2, 2023 09:23
@avandecreme avandecreme changed the title Fix escaping in R [R] Fix escaping in templates Feb 2, 2023
@wing328
Copy link
Member

wing328 commented Feb 10, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@avandecreme
Copy link
Contributor Author

Thanks, fixed and rebased

@wing328 wing328 added this to the 6.4.0 milestone Feb 16, 2023
@wing328
Copy link
Member

wing328 commented Feb 16, 2023

@avandecreme thanks for the PR.

Tested locally to confirm the issue and the fix.

@wing328 wing328 merged commit 12e76ec into OpenAPITools:master Feb 16, 2023
@avandecreme avandecreme deleted the fix_r_escaping branch February 16, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants