Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Julia client and server generators #14520

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

tanmaykm
Copy link
Contributor

@tanmaykm tanmaykm commented Jan 25, 2023

This PR adds two new generators for the Julia language

  • julia-client to generate a client from specifications
  • julia-server to generate a server with stubs that can be used to host a server conforming to the specifications

The generated code uses the Julia OpenAPI.jl package that includes support functions for both client and server.

Also fixes #782.
Similar to #1084, but uses OpenAPI.jl which supercedes the earlier Swagger.jl implementation.

cc: @wing328

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@tanmaykm
Copy link
Contributor Author

Thanks @wing328 for taking a look.
I have rebased with master and added b4042b4 to fix errors in the last ci run.

@tanmaykm
Copy link
Contributor Author

Looks like I need to rebase and run bin/utils/ensure-up-to-date as advised in the failure report?

This PR adds two new generators for the [Julia language](https://julialang.org/)
- `julia-client` to generate a client from specifications
- `julia-server` to generate a server with stubs that can be used to host a server conforming to the specifications

The generated code uses the Julia [OpenAPI.jl](https://github.com/JuliaComputing/OpenAPI.jl) package that includes support functions for both client and server.
@tanmaykm
Copy link
Contributor Author

Done that now in 1889ce0

@wing328
Copy link
Member

wing328 commented Jan 30, 2023

@tanmaykm thanks for the PR to add the new generator. I'll file another PR to make some minor improvements.

Can you please also PM me via Slack when you've time?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328 wing328 merged commit 4bc16ea into OpenAPITools:master Jan 30, 2023
@wing328 wing328 added this to the 6.3.0 milestone Jan 30, 2023
@tanmaykm
Copy link
Contributor Author

Thanks! Will do.

@wing328 wing328 changed the title Added a Julia client and server Added Julia client and server generators Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Julia] Add a Julia client generator
2 participants