Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rule to keep only the first tag #14465

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Add a rule to keep only the first tag #14465

merged 2 commits into from
Jan 20, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jan 15, 2023

when KEEP_ONLY_FIRST_TAG_IN_OPERATION is set to true, only keep the first tag in operation if there are more than one tag defined.

FYI @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Contributor

@Ghufz Ghufz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. this will serve the multi tag issue.

@wing328 wing328 added Enhancement: General OpenAPI Normalizer Normalize the spec for easier processing labels Jan 17, 2023
@wing328 wing328 added this to the 6.3.0 milestone Jan 17, 2023
@wing328 wing328 marked this pull request as ready for review January 17, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: General OpenAPI Normalizer Normalize the spec for easier processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants