Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14432: Do not add @Valid to Java types in "jaxrs-spec" generator #14435

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anatoliy-balakirev
Copy link

@Valid annotation is only needed for objects, where the cascading
validation is required. For standard Java types and enums it is useless.
Moreover, when those annotations are there for those types - Hibernate
Validator's performance degrades significantly (see:
https://hibernate.atlassian.net/browse/HV-1928 and
https://hibernate.atlassian.net/browse/HV-1933). I've checked other
available generators, and it looks like spring generates those
annotations properly. So I took the content of the modified files from
that generator and placed to the jaxrs-spec one.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann
    @Zomzog @lwlee2608 @cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog

`@Valid` annotation is only needed for objects, where the cascading
validation is required. For standard Java types and enums it is useless.
Moreover, when those annotations are there for those types - Hibernate
Validator's performance degrades significantly (see:
https://hibernate.atlassian.net/browse/HV-1928 and
https://hibernate.atlassian.net/browse/HV-1933). I've checked other
available generators, and it looks like `spring` generates those
annotations properly. So I took the content of the modified files from
that generator and placed to the `jaxrs-spec` one.
Updated samples, removing the excessive @Valid annotation. It is now not
added to the standard Java types and enums. The implementation is
identical to the `spring` generator.
@wing328
Copy link
Member

wing328 commented May 16, 2023

@anatoliy-balakirev can you please resolve the merge conflicts when you've time?

@wing328 wing328 added this to the 7.0.0 milestone May 16, 2023
@anatoliy-balakirev
Copy link
Author

Hi @wing328. I created this PR 4 months ago and it was never reviewed ever since. I don't want to spend more time on something, which seems to be not needed, sorry. I've also switched to the Spring generator in the meanwhile. If you're interested in these changes - feel free to pick them and create your own PR.

@wing328 wing328 modified the milestones: 7.0.0, 7.0.1 Aug 25, 2023
@robinjhector
Copy link
Contributor

Is this still on-track for 7.0.1? Seeing some pretty horrendous performance hits with this bug, in large request bodies. The worksaround for now is to completely disable bean validation via configOptions

@wing328 wing328 modified the milestones: 7.0.1, 7.1.0 Sep 19, 2023
@wing328 wing328 modified the milestones: 7.1.0, 7.2.0 Nov 13, 2023
@wing328 wing328 modified the milestones: 7.2.0, 7.3.0 Dec 22, 2023
@wing328 wing328 modified the milestones: 7.3.0, 7.4.0 Feb 8, 2024
@wing328 wing328 modified the milestones: 7.4.0, 7.5.0 Mar 11, 2024
@wing328 wing328 modified the milestones: 7.5.0, 7.6.0 Apr 17, 2024
@Gerschtli
Copy link

Seems to be fixed by #18302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants