Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ktor] Update generator to latest Ktor version #14061 #14296

Merged

Conversation

rsinukov
Copy link
Contributor

#14061

This is a breaking change, so I opened this PR into 7.0.x branch.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

@wing328
Copy link
Member

wing328 commented Jan 15, 2023

@rsinukov thanks for the PR. Will merge when we're approaching the 7.0.0 release.

@wing328
Copy link
Member

wing328 commented May 16, 2023

can you please resolve the merge conflicts when you've time? thank you

@wing328 wing328 changed the base branch from 7.0.x to master May 16, 2023 18:08
@rsinukov rsinukov force-pushed the rsinukov/ktor-server-update-2.1.1 branch from dd9a109 to 5c55e30 Compare May 16, 2023 21:40
@rsinukov
Copy link
Contributor Author

@wing328 done!

@rsinukov rsinukov force-pushed the rsinukov/ktor-server-update-2.1.1 branch from 5c55e30 to 431275c Compare May 16, 2023 21:54
@wing328 wing328 merged commit 7881482 into OpenAPITools:master May 21, 2023
16 checks passed
@wing328
Copy link
Member

wing328 commented May 21, 2023

LGTM. Thanks for the PR 👍

@jonolds
Copy link

jonolds commented Sep 14, 2023

just fyi, the docs still say 1.67. I was bummed for a sec but then I tested it and saw 2.1.3. Thank you so much for updating to ktor 2!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants