Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable access token refresh #14251

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

lisamburns
Copy link
Contributor

@lisamburns lisamburns commented Dec 12, 2022

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Lisa Burns added 2 commits December 12, 2022 13:00
- The client can now be configured with an access token getter proc
- The proc overrides the the static access token if it is set
@lisamburns
Copy link
Contributor Author

Hmmm, I am a first time contributor to this repo. Could someone help me troubleshoot my CI errors?

[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:3.0.0:repackage (default) on project openapi-camel: Execution default of goal org.springframework.boot:spring-boot-maven-plugin:3.0.0:repackage failed: Unable to load the mojo 'repackage' in the plugin 'org.springframework.boot:spring-boot-maven-plugin:3.0.0' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: org/springframework/boot/maven/RepackageMojo has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 52.0
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>org.springframework.boot:spring-boot-maven-plugin:3.0.0
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/home/circleci/.m2/repository/org/springframework/boot/spring-boot-maven-plugin/3.0.0/spring-boot-maven-plugin-3.0.0.jar
[ERROR] urls[1] = file:/home/circleci/.m2/repository/org/springframework/spring-context/6.0.2/spring-context-6.0.2.jar
[ERROR] urls[2] = file:/home/circleci/.m2/repository/org/springframework/spring-aop/6.0.2/spring-aop-6.0.2.jar

@wing328
Copy link
Member

wing328 commented Dec 14, 2022

@lisamburns please ignore the circleci failure (which only occurs starting a few days ago) for the time being.

@wing328
Copy link
Member

wing328 commented Dec 19, 2022

@lisamburns thanks for the PR. Have you tested it locally to ensure it works? (we do not have a test in place for access token at the moment)

From what I know it's a backward-compatible change. Please correct me if I'm wrong.

@lisamburns
Copy link
Contributor Author

Hello @wing328. Correct, this change should be backwards compatible because clients can just figure a static access_token and not configure the access_token_getter configuration. I tested it locally by copying the configuration.mustache and using that as a user-defined template to generate the ruby client, then ensuring resulting client can be configured with access_token or access_token_getter. Thanks for review.

@wing328
Copy link
Member

wing328 commented Dec 21, 2022

@lisamburns thanks for the details. Let's give it a try.

@wing328 wing328 merged commit 02d4852 into OpenAPITools:master Dec 21, 2022
@wing328 wing328 added this to the 6.3.0 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants