Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Fix declaration for arrays with object and array references #14198

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

tvrg
Copy link
Contributor

@tvrg tvrg commented Dec 7, 2022

For arrays with an item defined by reference to an array or an object,
the generated type declaration was Vec<core::models::Array> or
Vec<core::models::Map> without defining a Array or Map so that the
code didn't compile.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10)

@tvrg
Copy link
Contributor Author

tvrg commented Dec 12, 2022

Can I do something to fix the build? It complains about modifications to the typescript-axios client which I haven't touched knowingly.

@wing328
Copy link
Member

wing328 commented Dec 27, 2022

@tvrg can you please resolve the merge conflicts when you've time? I'll then take a look at the build errors if it still occurs.

For arrays with an item defined by reference to an array or an object,
the generated type declaration was `Vec<core::models::Array>` or
`Vec<core::models::Map>` without defining a `Array` or `Map` so that the
code didn't compile.
@tvrg
Copy link
Contributor Author

tvrg commented Dec 27, 2022

@wing328 Done!

@wing328 wing328 merged commit 88fa9ef into OpenAPITools:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants