Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle plugin publishing #14150

Merged

Conversation

erichaagdev
Copy link
Contributor

Publishing of the openapi-generator-gradle-plugin to Sonatype was broken following #13860 due to an incorrect task name in the Travis CI configuration. This PR replaces the incorrect task name (closeAndReleaseRepository) with the correct one (closeAndReleaseSonatypeStagingRepository).

I have created a Build Scan showing a dry run of the plugin publish following the update to Gradle 7.6: https://scans.gradle.com/s/zwwybxi6jbcam/console-log?page=1#L18

I also created a Build Scan showing a dry run of this process as it was in Gradle 5.6.4, from before my changes were made: https://scans.gradle.com/s/ngvxlsxc4fkyy/console-log?page=1#L15

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@erichaagdev
Copy link
Contributor Author

cc @wing328, @sorin-florea, @guylabs

@erichaagdev
Copy link
Contributor Author

FYI, since merging #13860 the lines to publish the Gradle plugin were temporarily removed so that other publications can continue. This is why it looks like I'm adding lines which were not there before.

You can see a diff between the .travis.yml file changes as they were in #13860 and this PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants