Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Change entrypoint to docker-entrypoint.sh #1413

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Nov 11, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

closes #1410

To make JAVA_OPTS available this PR changes ENTRYPOINT of CLI Docker image.

@ackintosh
Copy link
Contributor Author

cc @OpenAPITools/generator-core-team

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it locally yet but the enhancement looks reasonable to me.

@ackintosh ackintosh added this to the 3.3.3 milestone Nov 13, 2018
@ackintosh ackintosh merged commit c8837ea into OpenAPITools:master Nov 13, 2018
@ackintosh ackintosh deleted the fix-cli-image branch November 13, 2018 08:24
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The official OpenAPI Generator CLI Docker image does not respect JAVA_OPTS environment variable
2 participants