Fix the bug that the property generateApis always true #14126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Nov 30, 2022
modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultGenerator.java
Show resolved
Hide resolved
wing328
changed the title
|
let's give it a try. |
6 tasks
|
@wing328 @iWantUss I wanted to confirm if it has broken the functionality to provide the option of the selective apis to be generated. For example, if I want api "create_file" to be generated only, and provide the option as --global-property apis=create_file, then boolean generateApis is set as false because of Boolean.valueOf(GlobalSettings.getProperty(CodegenConstants.APIS)). Later on , generativeApi() method just returns because of this boolean value as false. |
|
@vmishra22 thanks for letting us know. Will revert the change via #15588 |
wing328
added a commit
that referenced
this pull request
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #14119