Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] exposes deserialized bodies for non-2XX responses #14095

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Nov 22, 2022

[python] exposes deserialized bodies for non-2XX responses
With this fix, for non 2XX responses, one can access exception.api_response.body to access body deserialized results
for non 2XX status codes.

This is a synonym PR for: openapi-json-schema-tools/openapi-json-schema-generator#91

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether changed the title [python] allow access to deserialized bodies for non-2XX response s [python] allow access to deserialized bodies for non-2XX responses Nov 22, 2022
@spacether spacether added this to the 6.3.0 milestone Nov 22, 2022
@spacether spacether changed the title [python] allow access to deserialized bodies for non-2XX responses [python] exposes deserialized bodies for non-2XX responses Nov 22, 2022
@spacether spacether merged commit 871eda2 into OpenAPITools:master Nov 22, 2022
@spacether spacether deleted the issue_14088_fix_include_non2XX_deserialization branch November 22, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Data model is lost for python generator when http code is not in 2XX
1 participant