Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Issue 13997 fix pass in model instances to new #14067

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Nov 18, 2022

[python] Issue 13997 fix pass in model instances to new
This PR is synonymous with openapi-json-schema-tools/openapi-json-schema-generator#82

@Linux13524
With my update, this test code passes when the models from the issue were generated:

ev = event.Event(name="test", properties={"name": "test"})
er = event_request.EventRequest(event=ev)
self.assertEqual(
    er,
    {
        'event': {
            'name': 'test',
            'properties': {'name': 'test'}
        }
    }
)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether added this to the 6.3.0 milestone Nov 18, 2022
@spacether spacether linked an issue Nov 18, 2022 that may be closed by this pull request
6 tasks
@spacether spacether merged commit 1748d03 into OpenAPITools:master Nov 18, 2022
@spacether spacether deleted the issue_13997_fix_python_pass_in_model_instances branch November 18, 2022 23:04
@OmarBouslama
Copy link

Hello
Thank you for the fix. When is the next tag planned with this fix included ?

@spacether
Copy link
Contributor Author

Not sure, whenever @wing328 decides to do a release

@OmarBouslama
Copy link

ok, we would really appreciate a new release soon if this is possible. In fact this issue is blocking us from generating (and updating old SDKs) SDKs with the lastest openapi-generator

@spacether
Copy link
Contributor Author

spacether commented Jan 10, 2023

If you need this sooner, how about using this release, which has the feature that you need?
https://github.com/openapi-json-schema-tools/openapi-json-schema-generator/releases/tag/1.0.4

@OmarBouslama
Copy link

what is the difference between openapi-generator and openapi-json-schema-generator ?

@spacether
Copy link
Contributor Author

spacether commented Jan 12, 2023

openapi-json-schema-generator for now contains the python generator only and the project's goals and history are described in its readme here: https://github.com/openapi-json-schema-tools/openapi-json-schema-generator#5---about-us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Python] Handling objects as dictionnaries not working in 6.2.1
2 participants