-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix return_type parameter examples in ruby-client #1399
Conversation
@meganemura thanks for the PR. Can you please run |
960969a
to
f5584b2
Compare
In By the way, do we need |
I think we need to update some java samples since the build of master branch is broken. https://circleci.com/gh/OpenAPITools/openapi-generator/3274#tests/containers/2
|
@meganemura right. I've fixed the issue in master via #1405. Thanks again for your contribution 👍 |
@meganemura thanks again for the PR, which has been included in the v3.3.3 release: https://twitter.com/oas_generator/status/1062929948191510528 |
* Fix return_type parameter examples * $ bin/openapi3/ruby-client-petstore.sh
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.4.x
,4.0.x
. Default:master
.Description of the PR
Fix the wrong examples of return_type.
We need
<>
brackets for parsing return_type.See:
openapi-generator/modules/openapi-generator/src/main/resources/ruby-client/api_client.mustache
Lines 195 to 204 in 3494542