-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable subschemas #13850
Nullable subschemas #13850
Conversation
Ah, this appears to have a wider effect than anticipated. |
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Hi @wing328 I think that's fixed now? |
Hi @wing328 anything more needed from me on this? |
@wing328 Can we get this MR merged? |
Checking on this again, could we please merge this in? |
@wing328 |
cc @OpenAPITools/generator-core-team |
Sorry for the delay in reviewing this fix. We can accept this for the time being and moving forward we'll likely the move the fix to OpenAPI Normalizer, which will be introduced by #14172. |
thanks @wing328 - the normalizer looks like a much more sensible approach going forward |
Fixes #12838 in the same way #13303 by not generating a new inline model if the only difference is in
readOnly
or, now,nullable
.