Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable subschemas #13850

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Conversation

mrginglymus
Copy link
Contributor

Fixes #12838 in the same way #13303 by not generating a new inline model if the only difference is in readOnly or, now, nullable.

@mrginglymus
Copy link
Contributor Author

Ah, this appears to have a wider effect than anticipated.

@wing328
Copy link
Member

wing328 commented Oct 31, 2022

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@mrginglymus
Copy link
Contributor Author

Hi @wing328 I think that's fixed now?

@mrginglymus
Copy link
Contributor Author

Hi @wing328 anything more needed from me on this?

@c0dezli
Copy link

c0dezli commented Dec 2, 2022

@wing328 Can we get this MR merged?

@c0dezli
Copy link

c0dezli commented Dec 11, 2022

Checking on this again, could we please merge this in?

@c0dezli
Copy link

c0dezli commented Dec 11, 2022

@wing328
I'm sure I'm not the only one blocked by the bug this PR fixes for almost over a year and cannot upgrade to OpenAPI 6+, could we please merge this in?
Thank you very much!

@wing328
Copy link
Member

wing328 commented Dec 22, 2022

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Dec 22, 2022

Sorry for the delay in reviewing this fix. We can accept this for the time being and moving forward we'll likely the move the fix to OpenAPI Normalizer, which will be introduced by #14172.

@wing328 wing328 merged commit 71a7a82 into OpenAPITools:master Dec 22, 2022
@wing328 wing328 added the Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf label Dec 22, 2022
@wing328 wing328 added this to the 6.3.0 milestone Dec 22, 2022
@mrginglymus mrginglymus deleted the nullable-subschemas branch December 22, 2022 15:49
@mrginglymus
Copy link
Contributor Author

thanks @wing328 - the normalizer looks like a much more sensible approach going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf Issue: Bug
Projects
None yet
3 participants