Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GO] fix: stops checking for nil for structs #13843

Merged

Conversation

NickUfer
Copy link
Contributor

Fixes #13842

See #13842 for issue description

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

@NickUfer NickUfer force-pushed the go_fix_invalid_nil_check_for_structs branch from d851e0c to ca3e946 Compare October 27, 2022 18:35
@wing328
Copy link
Member

wing328 commented Oct 31, 2022

tested locally and able to confirm the fix.

@wing328 wing328 added this to the 6.2.1 milestone Oct 31, 2022
@wing328 wing328 merged commit a04b262 into OpenAPITools:master Oct 31, 2022
gssbzn added a commit to gssbzn/openapi-generator that referenced this pull request Nov 4, 2022
This corrects the identation for recnet changes in OpenAPITools#13843
wing328 pushed a commit that referenced this pull request Nov 5, 2022
* [GO] fix identation for model_simple.mustache

This corrects the identation for recnet changes in #13843

* running the scripts
@wing328
Copy link
Member

wing328 commented Nov 7, 2022

FYI. I've filed #13940 as a follow-up PR to regenerate tests and replace 4-space with tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][GO] generation of nil check for struct
2 participants