-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring request mapping mode #13838
Merged
wing328
merged 8 commits into
OpenAPITools:master
from
cachescrubber:spring_request_mapping_mode
Nov 1, 2022
Merged
Spring request mapping mode #13838
wing328
merged 8 commits into
OpenAPITools:master
from
cachescrubber:spring_request_mapping_mode
Nov 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note to self. IIRC, we need to restore the. useFeignClientUrl functionality introduced in #12250 |
borsch
approved these changes
Oct 27, 2022
rlagoue
approved these changes
Oct 27, 2022
welshm
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments about naming and defaults - but looks great thanks for fixing!
pstorch
added a commit
to pstorch/openapi-generator
that referenced
this pull request
Jun 10, 2024
… the generated class level RequestMapping annotation Based on OpenAPITools#13838 but for kotlin-spring. Fixes OpenAPITools#18884
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestMappingMode: Explicit configuration to control the location of the generated class level RequestMapping annotation
Since #10573, the
@ RequestMapping
has been moved from the controller to the generated api interface.This introduced incompatibilities in many scenarios, but specially when spring-cloud is used as a library. Unfortunately the fix from @MelleD (#13546) does not allow to override the default (for example when using interfaceOnly). This PR introduces a dedicated cli option to decide where the RequestMapping annotation should be placed.
`
requestMappingMode
Where to generate the class level @RequestMapping annotation. (Default: controller)
iface - Generate the @RequestMapping annotation on the generated Api Interface.
controller - Generate the @RequestMapping annotation on the generated Api Controller Implementation.
none - Do not add a class level @RequestMapping annotation.
`
The default is controller, which is the same as before #10573. By explicitly using iface, the annotation could be added to the api interface.
Caused By
Based on
Fixes
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)