-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for issue #13722: send body for application/x-www-form-urlencoded data #13723
fix for issue #13722: send body for application/x-www-form-urlencoded data #13723
Conversation
…m-urlencoded data
modules/openapi-generator/src/main/resources/python/api_client.handlebars
Show resolved
Hide resolved
Hey there, thank you for your PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments for needed changes to get CI tests passing and add a verification endpoint test
modules/openapi-generator/src/main/resources/python/api_client.handlebars
Show resolved
Hide resolved
samples/openapi3/client/petstore/python/tests_manual/test_request_body.py
Outdated
Show resolved
Hide resolved
As a newbie in this repo (and with the recent swap of python-experimental to python), I'm having a bit of trouble finding the right place to add a verification endpoint test. Can you recommend a file or directory where I should add the test and/or the command to run the test? |
Sure thing. Here are the steps:
|
Thanks for the pointers. I added a verification endpoint test, but am not really happy with the Also... Please let me know if you want me to have a look at using the fields option for urllib3. It's possible that I might be able to get it to work (but using fields will require changes over more code files). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for adding the test!
CI failure is unrelated |
I wanted the fields removed from the call not used. No need to futz with it. |
Fix for issue #13722: verified with successful calls to /v5/oauth/token endpoints for https://github.com/pinterest/api-description
@spacether
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)