Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] [NATIVE] Fix exploded query parameters with array property #13656

Conversation

sorin-florea
Copy link
Contributor

@sorin-florea sorin-florea commented Oct 10, 2022

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sorin-florea sorin-florea changed the title Fix exploded query parameters with array property [JAVA] [NATIVE] Fix exploded query parameters with array property Oct 10, 2022
@sorin-florea
Copy link
Contributor Author

@sorin-florea sorin-florea force-pushed the sorin/fix-array-exploded-query-params branch from a75f14b to efe84ca Compare October 10, 2022 13:02
@sorin-florea
Copy link
Contributor Author

@wing328

@wing328
Copy link
Member

wing328 commented Nov 1, 2022

thanks for the PR. did some tests locally and the result is good:

.11:16:05.466582 IP localhost.54965 > localhost.http: Flags [P.], seq 1310217848:1310218138, ack 453009728, win 6379, options [nop,nop,TS val 956929808 ecr 4267036754], length 290: HTTP: GET /api?values=Buenos%20Aires&values=C%C3%B3rdoba&values=La%20Plata HTTP/1.1

@wing328 wing328 added this to the 6.2.1 milestone Nov 1, 2022
@wing328 wing328 merged commit 9eb799d into OpenAPITools:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants