Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ensure-up-to-date script #1362

Merged
merged 5 commits into from
Nov 2, 2018
Merged

Improve ensure-up-to-date script #1362

merged 5 commits into from
Nov 2, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 2, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Improve ensure-up-to-date script to show error messages when failing to run the script
  • fix permission issues of the scripts under the "bin" folder.

cc @OpenAPITools/generator-core-team

@wing328 wing328 added this to the 3.3.3 milestone Nov 2, 2018
@wing328 wing328 changed the title Improve ensure-up-to-date script [WIP] Improve ensure-up-to-date script Nov 2, 2018
@wing328 wing328 changed the title [WIP] Improve ensure-up-to-date script Improve ensure-up-to-date script Nov 2, 2018
@wing328 wing328 merged commit 36991a4 into master Nov 2, 2018
@wing328 wing328 deleted the improve-ensure-up-to-date branch November 2, 2018 09:19
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* improve ensure-up-to-date script

* trigger build failure

* use exit 1 instead

* fix build failure

* update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant