-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Kotlin Vert.x client #13594
Added Kotlin Vert.x client #13594
Conversation
Kotlin vertx client fix
added api abstractions to client generator
multiline content type
cc @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) |
can you please resolve the merge conflicts when you've time? |
@wing328 conflicts resolved |
I got some errors when testing the new kotlin vertx client:
Here is the config I used:
Does it work you locally? Please also add the config to your PR and include the samples. then add a new item in https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-kotlin-client.yaml#L53 to make sure it's tested when samples change. |
@wing328 fixed issue you discovered and added samples for kotlin-jvm-ktor-gson, kotlin-jvm-vertx-gson, kotlin-jvm-vertx-jackson, kotlin-jvm-vertx-jackson-coroutines and kotlin-jvm-vertx-moshi generators (all included into samples-kotlin-client.yaml) |
LGTM. Thanks for the PR 👍 |
Added support for Vert.X library into Kotlin Client generator. New generator can be tested using kotlin-client generator with vertx library.
Ping @jimschubert
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)