Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Bugfix: DateTime object on query #13583

Merged

Conversation

thomasphansen
Copy link
Contributor

This PR fixes bug #7712. PR #11225 was a major step to fix query params support (thanks, @nadar! 😄), but it left out DateTime objects (which were supported previously, through the ::toString() method).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon

@wing328 wing328 added this to the 6.2.1 milestone Oct 6, 2022
@wing328
Copy link
Member

wing328 commented Oct 6, 2022

LGTM.

@wing328 wing328 merged commit a37d18a into OpenAPITools:master Oct 6, 2022
@nadar
Copy link
Contributor

nadar commented Oct 6, 2022

Sorry for the introduced break. Unit Tests FTW :-)

jayandran-Sampath pushed a commit to jayandran-Sampath/openapi-generator that referenced this pull request Oct 6, 2022
* [PHP] BUGFIX: fix code breaking when query params contain a DateTime object

* [PHP] Autogenerated files
@thomasphansen thomasphansen deleted the th_php_bugfix_datetime_on_query branch October 8, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants