Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resteasy: fix string comparison #134

Merged
merged 4 commits into from
May 23, 2018
Merged

Conversation

jmini
Copy link
Member

@jmini jmini commented May 23, 2018

I did just run bin/jaxrs-resteasy-eap-petstore-server.sh to update samples/server/petstore/jaxrs-resteasy/. And I got this result.

Some behavior has changed: The problem is that:

  • PetApiServiceImpl
  • StoreApiServiceImpl
  • UserApiServiceImpl

Are removed.
And DefaultApiServiceImpl is created instead.

I guess this is just the grouping setting that has changed...


If you build the project and run it at d5d8c35 the sample folder is up-to-date. Later a change was introduced that changes

This is an other proof that we need #80


@jimschubert has a script to do a git bisect somewhere I need to investigate.

For the moment I did it manually and found that cc29417 is already broken...

Update 'samples/server/petstore/jaxrs-resteasy/'
@jmini
Copy link
Member Author

jmini commented May 23, 2018

I found the problem:

It was introduced with 9ecd358. I will fix it.

@wing328
Copy link
Member

wing328 commented May 23, 2018

Oops.. sorry. It was my bad. Please help fix it.

I've reviewed other changes in that commit and look ok to me. Please also take a look when you have time.

@jmini jmini changed the title WIP: problem with resteasy in samples resteasy: fix string comparison May 23, 2018
@jmini
Copy link
Member Author

jmini commented May 23, 2018

@wing328: for me 18a2b9e is the only thing that is requested to fix 9ecd358. The rest of commit 9ecd358 looks good to me.

@jmini jmini added this to the 3.0.0 milestone May 23, 2018
@jmini jmini merged commit 3f81378 into OpenAPITools:master May 23, 2018
@jmini jmini deleted the update_resteasy branch May 23, 2018 06:38
nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this pull request Apr 6, 2023
…ript-4.x

chore(deps): update dependency typescript to v4.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants