Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust-server] Enables the use of text/html responses as plaintext #1329

Merged
merged 3 commits into from
Nov 5, 2018
Merged

[rust-server] Enables the use of text/html responses as plaintext #1329

merged 3 commits into from
Nov 5, 2018

Conversation

bjgill
Copy link
Contributor

@bjgill bjgill commented Oct 26, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @frol @farcaller

Description of the PR

Builds on #1180 by @colelawrence. This addition to the rust-server generator enables the use of text/html responses as plaintext.

I've added an html endpoint to the sample to demonstrate that this works (and fixed the problem that that uncovered).

@bjgill
Copy link
Contributor Author

bjgill commented Oct 29, 2018

The CI failure was erlang-caused and so seemingly unrelated.

I'll leave this for a few days in case anyone wants to review/comment. Otherwise, I reviewed the precursor PR so am happy to merge if no comments are forthcoming.

@bjgill bjgill merged commit 30bfebf into OpenAPITools:master Nov 5, 2018
@bjgill bjgill deleted the rust-server-html branch November 5, 2018 16:14
@wing328 wing328 added this to the 3.3.3 milestone Nov 14, 2018
@wing328 wing328 changed the title Rust server html [rust-server] Enables the use of text/html responses as plaintext Nov 14, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Builds on OpenAPITools#1180 by @colelawrence. This addition to the rust-server generator enables the use of text/html responses as plaintext.

I've added an html endpoint to the sample to demonstrate that this works (and fixed the problem that that uncovered).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants