Fix go code generator for oneOf #13167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@mariotoffia thanks for the fix. Can you please PM me via Slack when you've time? Just a few quick questions. https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) |
|
Any update on this? We have also encountered this issue internally, and are waiting on this fix. |
dimuon
added a commit
to dimuon/terraform-provider-elasticstack
that referenced
this pull request
Apr 12, 2023
OpenApi generator produces incorrect code for `RunConnector200ResponseData` in generated/kibanaactions/model_run_connector_200_response_data.go It doesn't strip curly braces from the field names. It looks like there is a fix for the issue: OpenAPITools/openapi-generator#13167 As for now the code is fixed manually.
dimuon
added a commit
to dimuon/terraform-provider-elasticstack
that referenced
this pull request
Apr 12, 2023
OpenApi generator produces incorrect code for `RunConnector200ResponseData` in generated/kibanaactions/model_run_connector_200_response_data.go It doesn't strip curly braces from the field names. It looks like there is a fix for the issue: OpenAPITools/openapi-generator#13167 As for now the code is fixed manually.
Member
|
the latest master has better support for oneOf in the go client generators. please give it a try. if this PR is still needed, please file a new one instead. thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #13166