Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name sanitation when using kebab case filenaming #1314

Merged
merged 2 commits into from
Nov 7, 2018

Conversation

smasala
Copy link
Contributor

@smasala smasala commented Oct 25, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes: #1253

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09)

@wing328
Copy link
Member

wing328 commented Nov 4, 2018

If no question on this PR, I'll merge it on coming Wednesday.

@smasala
Copy link
Contributor Author

smasala commented Nov 4, 2018

Thanks 👍

@wing328 wing328 merged commit 73162cb into OpenAPITools:master Nov 7, 2018
@wing328 wing328 changed the title fix name sanitation when using kebab case filenaming Fix name sanitation when using kebab case filenaming Nov 7, 2018
@wing328
Copy link
Member

wing328 commented Nov 15, 2018

@smasala thanks for the PR, which has been included in the v3.3.3 release: https://twitter.com/oas_generator/status/1062929948191510528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants