[elm] Add flag to prefix custom type variants #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriktim
force-pushed
the
elm-customtypeprefix
branch
from
7a0afc2
to
43456c6
Compare
wing328
reviewed
Oct 23, 2018
| @@ -61,13 +61,15 @@ | |||
| private ElmVersion elmVersion = ElmVersion.ELM_019; | |||
|
|
|||
| private static final String ELM_VERSION = "elmVersion"; | |||
| private static final String PREFIX_CUSTOM_TYPE_VARIANTS = "prefixCustomTypeVariants"; | |||
There was a problem hiding this comment.
@trenneman Since the option is Elm specified, what about naming it as "elmPrefixCustomTypeVariants"?
There was a problem hiding this comment.
Good point, I'll update the PR.
eriktim
force-pushed
the
elm-customtypeprefix
branch
from
43456c6
to
d7d4803
Compare
|
@trenneman thanks for the PR, which is included in the v3.3.2 release: https://twitter.com/oas_generator/status/1057649626101112832 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Fixes #309 adding support for an additional CLI option:
--additional-properties prefixCustomTypeVariants=true