Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v303 unit test spec, adds post json request bodies #12875

Merged
merged 11 commits into from
Jul 21, 2022

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jul 14, 2022

v303 unit test spec, adds post json request bodies
Fixes a python-experimental bug where enums with the value 1 stored the wrong value in the instance
Test coverage increased from 68% to 86%
python-experimental allow patterns that don't start and end with slashes because json schema tests include regexes without those slashes

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether added this to the 6.1.0 milestone Jul 14, 2022
@spacether spacether marked this pull request as draft July 14, 2022 23:58
@spacether spacether marked this pull request as ready for review July 21, 2022 21:48
@spacether spacether merged commit d1c2230 into OpenAPITools:master Jul 21, 2022
@spacether spacether deleted the feat_adds_post_requestBodies branch July 21, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant