Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for inheritance in Swashbuckle in ASP.NET Core #12856

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

knom
Copy link
Contributor

@knom knom commented Jul 13, 2022

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI: @mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti @wing328

Added the support for polymorphism in models to ASP.NET Core generator.
So that Swashbuckle SwaggerGen re-outputs a correct swagger schema with ALLOF.

@wing328 wing328 added this to the 6.1.0 milestone Jul 21, 2022
@wing328 wing328 merged commit 17c021d into OpenAPITools:master Jul 21, 2022
@wing328
Copy link
Member

wing328 commented Jul 21, 2022

LGTM.

@wing328
Copy link
Member

wing328 commented Jul 21, 2022

FYI. It turns out this feature only available in swashbuckle 6.0+ so I've update swashbuckle version to the latest (6.4.0) via #12965.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants